Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: support config background tasks resource limit #18945

Merged
merged 8 commits into from
Oct 15, 2024
Merged

resource_control: support config background tasks resource limit #18945

merged 8 commits into from
Oct 15, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Sep 19, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@glorv glorv requested review from nolouch and hfxsd September 19, 2024 07:04
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@Oreoxmt Oreoxmt added v8.4 This PR/issue applies to TiDB v8.4. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 19, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 19, 2024
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Sep 20, 2024
hfxsd
hfxsd reviewed Sep 24, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 24, 2024
View reviewed changes
dynamic-config.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 24, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 24, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 24, 2024
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from lilin90 September 24, 2024 03:48
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv glorv requested review from cfzjywxk and songrijie and removed request for cfzjywxk September 25, 2024 01:18
qiancai
qiancai reviewed Sep 30, 2024
View reviewed changes
dynamic-config.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-resource-control.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 30, 2024
glorv
glorv commented Sep 30, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
@glorv
Copy link
Contributor Author

glorv commented Sep 30, 2024

@nolouch PTAL

@lilin90 lilin90 removed their request for review October 8, 2024 07:39
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-30 07:21:50.490129767 +0000 UTC m=+253065.910342776: ☑️ agreed by qiancai.
  • 2024-10-09 02:23:12.925442487 +0000 UTC m=+1012748.345655499: ☑️ agreed by hfxsd.

@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit f74217a into pingcap:master Oct 15, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@hfxsd hfxsd hfxsd approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@songrijie songrijie Awaiting requested review from songrijie

Assignees

@hfxsd hfxsd

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glorv @hfxsd @songrijie @qiancai @Oreoxmt